Is there any plan to support bower installs?

[vikalpj]

We are supporting bower installs in our project and found this awesome library for infinite scrolling. For now we forked the repo and and added a bower config to support bower installs. Is there any plan to support bower installs?

[graingert]

@vikalpj currently no plan as including a built copy of ngInfiniteScroll was becoming a maintenance burden. (Eg it was out of date to the source, or it made merges very difficult as the built files always conflicted)

[graingert]

@vikalpj if you have bower installed you also have npm installed, you can run "npm install --save ng-infinite-scroll" and use

<script src="./node_modules/ng-infinite-scroll/build/ng-infinite-scroll.js"></script>

[vikalpj]

@graingert Let me try it out automating the build and push through travis and get back to you with a solution :)..

[graingert]

@vikalpj if I can get an automated build that keeps built files out of master, I'll consider reintroducing bower.

[vandesh]

@graingert : Isn't it already available on bower? bower install ngInfiniteScroll#1.0.0

[EricSmekens]

@vandesh Yes, there is, but that seems to be an old version.

[vikalpj]

@graingert I have automated the stuff to make the builds from travis. I have used https://github.com/sroze/ngInfiniteScroll-bower package to have the final output. The build will be made only when we push a tag to the repo. Otherwise travis will only run the test cases. There would be some changes needed once you look at the implementation and plan to merge it.

I have tried to follow something like https://gist.github.com/domenic/ec8b0fc8ab45f39403dd#get-encrypted-credentials to commit the things to ngInfiniteScroll-bower repo.

[graingert]

Looks good I'd probably rather use github API keys. I can add those to the Travis web UI

[vikalpj]

there is a note on the above Gist

NOTE: an earlier version of this guide recommended generating a GitHub personal access token and encrypting that. Although this is simpler, it is not a good idea in general, since it means any of your repository's collaborators would be able to edit the Travis build script to email them your access token, thus giving them access to all your repositories. The repository-specific deploy key approach is safer.

Which pretty much makes sense to me.

I will create a gist how you can configure your repository and make the necessary changes to the commit most probably by tomorrow. Let me know if you have some different plans to change the script to use github api keys

[graingert]

Boo, I was hoping I could generate an API key just for this repo

[vikalpj]

@graingert this gist contains the steps to merge the above branch. Made the required changes on above pull request.

[vikalpj]

@graingert Any updates on this, I can help you to deploy/merge this if needed.

[graingert]

I'd like it updated to only push the dist files into https://github.com/ng-infinite-scroll/ng-infinite-scroll-bower

[vikalpj]

@graingert Sure, Updating the script, but for adding the keys and all would need to follow this gist.

[graingert]

I will do that, don't worry

[mephinet]

Hmm, the tag you pushed 3 days ago broke our software, I had to downgrade to 1.3.0: https://github.com/sroze/ngInfiniteScroll/tree/1.3.1 does not have a build dir at all, and bower update seems to still check this repo instead of the ng-infinite-scroll repo. Are users required to change something in their bower.json?

[graingert]

@mephinet you should install 'ng-infinite-scroll' from npm. Instructions for legacy bower use are on the readme https://github.com/sroze/ngInfiniteScroll/blob/master/README.md#bower

You'll also need to comply with the new AGPL license. The npm version will always be compatible with the MIT license.

[mephinet]

Ah, sorry, I didn't get that hint (even though I had a smile when I saw the package name) - thanks!

[BinaryMuse]

Is it possible to backfill the older versions/tags that Bower currently lists for ngInifiteScroll into the ng-infinite-scroll-bower repo?

Available versions:
  - 1.3.1
  - 1.3.0
  - 1.2.2
  - 1.2.1
  - 1.2.0
  - 1.1.2
  - 1.1.1
  - 1.1.0
  - 1.0.0
  - 0.2.0
  - 0.1.0

If we could ensure that things won't break for people using Bower pre-1.3.0, I could re-register the ngInfiniteScroll name to point to the new repo.

[graingert]

@BinaryMuse yeah I can do this quite easily

[graingert]

@BinaryMuse done: https://github.com/ng-infinite-scroll/ng-infinite-scroll-bower/releases

[graingert]

@BinaryMuse, can you re-register ngInifiteScroll to the https://github.com/ng-infinite-scroll/ng-infinite-scroll-bower/ repo?