search

srrDB / pyrescene

MIT License
56 stars 11 forks source link

Replace distutils deprecated functions for Python 3.x #5

Closed dguglielmi closed 1 year ago

SpiralBrad commented 1 year ago

@srrDB @hrxcodes @itzoke Why has this not been merged yet?

itzoke commented 1 year ago

@SpiralBrad, no idea and I don't have any rights to push/merge. From what I can tell the diff looks good.

On a side note, this should probably be done together with a change of the first line of each file from env python to env python3 to make sure that python3 is used. However my python experience is very limited so I may be wrong on this.

dguglielmi commented 1 year ago

@itzoke : I agree, as Python 2.x is end of life for years now, it's seems a good idea to also change the shebang of all scripts to "env python3" for sure. Do you want me to update the PR to included that change too or maybe open another PR ?

itzoke commented 1 year ago

I'm not calling any shots on this. So I'll let someone with merge privileges answer this.

hrxcodes commented 1 year ago

Would have been great to also put into the description why this change is done. Python 3.12 removes distutils

If we can avoid breaking support for python2 we should. Can you make this check python versions and import the necessary modules based on py2 & py3 so it works on both?

dguglielmi commented 1 year ago

@hrxcodes it's done