search

srs / gradle-node-plugin

Gradle plugin for integrating NodeJS in your build. :rocket:
Apache License 2.0
866 stars 211 forks source link

Fix race condition with parallel execution #282

Closed fluxroot closed 4 years ago

fluxroot commented 6 years ago

If another task executes in parallel and uses the project repositories, there's a possible race condition where the other task only gets our distBaseUrl repository. We should not wipe the repository list. Instead only add and remove our distBaseUrl repository.

fluxroot commented 4 years ago

Closing this PR as this project seems to be quite dead.

deepy commented 4 years ago

This has been solved in the https://github.com/node-gradle/gradle-node-plugin fork since a while ago

fluxroot commented 4 years ago

@deepy Is the repo you're referring to a fork?

deepy commented 4 years ago

Yeah, you can see the history in https://github.com/srs/gradle-node-plugin/issues/315

Initially we kept the fork relationship on github, but since we're by now pretty far ahead of this repo we had that removed.

The early versions are drop-in replacements, but at 2.x we dropped gulp/grunt as these could be handled just as well with npx (and added a cost to maintenance)

fluxroot commented 4 years ago

I see. Thanks for this clarification. I guess we'll switch to the new project then. Keep it up!