srs / gradle-node-plugin

Gradle plugin for integrating NodeJS in your build. :rocket:
Apache License 2.0
866 stars 211 forks source link

Fix issue with GRADLE_METADATA #296

Open ilmat192 opened 6 years ago

ilmat192 commented 6 years ago

When Gradle 4.6 or higher is used and the GRADLE_METADATA feature is enabled (e.g. by applying the cpp-application plugin), a build fails to resolve the Node distribution as a dependency. This patch fixes this issue using explicitly specified metadata sources.

See details: https://github.com/gradle/gradle/issues/5008

ilmat192 commented 6 years ago

Just noticed that the metadataSources method was introduced only in Gradle 4.5. So if we don't want to drop old versions of Gradle, such a solution will be inappropriate.

But anyway these changes in Gradle's dependency management should be taken into account. Looks like a Node Maven repo mentioned here will be a good solution.