search

srs / gradle-node-plugin

Gradle plugin for integrating NodeJS in your build. :rocket:
Apache License 2.0
866 stars 211 forks source link

Fix Gradle 6.0 Deprecations #316

Closed cdietrich closed 2 years ago

cdietrich commented 5 years ago

When running with Gradle 5.0 i am getting following deprecation warning

> Task :nodeSetup
The IvyArtifactRepository.layout(String, Closure) method has been deprecated. This is scheduled to be removed in Gradle 6.0. Please use the IvyArtifactRepository.patternLayout(Action) method instead.
cdietrich commented 5 years ago

@deepy am not sure if the can and should be done right know. patternLayout is still incubating api

deepy commented 5 years ago

I'm strangely enough not getting this warning on https://github.com/node-gradle/gradle-node-plugin, not even with --warning-mode all

cdietrich commented 5 years ago

are you sure you execute nodeSetup actually?

cdietrich commented 5 years ago

https://github.com/cdietrich/gradle-node-plugin-issue316

deepy commented 5 years ago

~~I'm not getting this in my local test repo, which apart from using the old plugin syntax is seemingly identical, strange. Your test-case works brilliantly though!~~ It's Friday! Local gradle was 5.0, wrapper was 4.10.2.

cdietrich commented 2 years ago

switched to node-gradle/gradle-node-plugin which has my fix