srs / gradle-node-plugin

Gradle plugin for integrating NodeJS in your build. :rocket:
Apache License 2.0
866 stars 211 forks source link

Start using @CompileStatic for groovy code where it can be used #325

Closed srs closed 5 years ago

chrisgahlert commented 5 years ago

Don't do that... I developed the Gradle plugin gradle-dcompose-plugin and started using @CompileStatic in the beginning. This caused major problems, when the Groovy version, that this plugin was compiled with was used with older Groovy versions. Therefore this essentially broke my Gradle backwards compatibility, when different Gradle versions were using different versions of Groovy.

My solution was to use @TypeChecked where appropriate.

imanushin commented 5 years ago

@srs, possible it is better just to use Kotlin inside this plugin (instead of gradle)? Then plugin will work faster.

Moreover - key Groovy developer Cédric Champeau started to use Kotlin inside the Groovy build scripts - please check commit here.

srs commented 5 years ago

Thanks @chrisgahlert and @imanushin. Will not do that. I am in the process of converting the plugin to use plain old Java. Just closing this issue.