search

srs / gradle-node-plugin

Gradle plugin for integrating NodeJS in your build. :rocket:
Apache License 2.0
867 stars 210 forks source link

fix npx symlink creation #338

Closed mmayer1 closed 2 years ago

mmayer1 commented 5 years ago

When gradle installs on linux/mac, it seems the npm and npx symlinks were not correct. Code in SetupTask had been added to solve it for npm. This change simply adds support for npx as well.

In our package.json, we have a script that used npx as that's the only way a tool we're using advertises that we can run certain commands.

`"build-something" : "npx sencha app build"`

Without this PR, npx is an empty file that does nothing. With this fix, we can use our npx package.json scripts from gradle NpmTask.

asoftwareguy commented 5 years ago

I believe this also fixes #312

asoftwareguy commented 5 years ago

@srs was curious of when we might be able to get this merged

Ingo-FP-Angel commented 4 years ago

Any chance of this getting merged?

mmayer1 commented 4 years ago

My organization changed over to use https://github.com/node-gradle/gradle-node-plugin

In build.gradle we used id 'com.github.node-gradle.node' version '2.2.0'

https://plugins.gradle.org/plugin/com.github.node-gradle.node

Which fixes the issue

mmayer1 commented 2 years ago

I'm closing since it probably won't get merged at this point and I no loner need this