srs / gradle-node-plugin

Gradle plugin for integrating NodeJS in your build. :rocket:
Apache License 2.0
864 stars 212 forks source link

Bad console output formatting #345

Closed pun-ky closed 5 years ago

pun-ky commented 5 years ago

The output in console should look like table with colors but it looks like below

image

image

I suspect that the reason is bad encoding when proxing output of process executing node and passing it through stdout.

When I was using jest+puppetter (now I am using cypress.io) and running it by yarn task provided by this plugin, the console output was also wrong.

But when I run it directly in console, the output is correct:

image

Any ideas what need to be fixed in plugin?

pun-ky commented 5 years ago

maybe Gradle's project.exec used here https://github.com/srs/gradle-node-plugin/blob/master/src/main/groovy/com/moowork/gradle/node/exec/ExecRunner.groovy#L37 is not good enough in that case. my friend recommended me that for executing processes and having correct output, maybe it will help in that case also? implementation("org.buildobjects:jproc:2.2.3")

if I find some time I will try to fix it / impl PR but not sure right now. Still any help / comments appreciated.

pun-ky commented 5 years ago

it's a Git Bash issue when embedded in IntelliJ. closing as of plugin code is ok