search

srs / gradle-node-plugin

Gradle plugin for integrating NodeJS in your build. :rocket:
Apache License 2.0
867 stars 210 forks source link

System architecture aarch64 is not detected as arm #346

Open mugglmenzel opened 4 years ago

mugglmenzel commented 4 years ago

Some devices with arm architecture are indicated by the java system property "os.arch" as aarch64 (e.g. the Coral Dev Board). However, the current arch detection mechanism in PlatformHelper would identify such a device (or OS) as x64: https://github.com/srs/gradle-node-plugin/blob/master/src/main/groovy/com/moowork/gradle/node/util/PlatformHelper.groovy#L59

Thereby the wrong nodejs version is downloaded and cannot be installed on those devices. The whole build process fails.

deepy commented 4 years ago

We re-arranged the conditionals and added a startsWith('aarch') in the https://github.com/node-gradle/gradle-node-plugin fork, which should hopefully solve this