Update View/Helper/UploadHelper.php

srs81 / CakePHP-AjaxMultiUpload

CakePHP 2 plugin to allow for easy multi-file upload with AJAX

Other

65 stars 32 forks source link

Update View/Helper/UploadHelper.php #24

Closed plugs closed 12 years ago

plugs commented 12 years ago

Hi,

replaced "id" with "class" - it works in IE as well.

is there a need for loop? didn't figure it out, but amuCollection.length is always 1 pls correct me if i'm wrong

srs81 commented 12 years ago

Thanks for the commit. This will also solve issue #23. The problem is that IE doesn't support getElementsByClassName. Do you want to perhaps merge in the function referred to in this answer - that checks for IE and adds the function, so that way, your patch should work on IE and other browsers.

plugs commented 12 years ago

Thank you for this nice plugin! It's very uncomplicated and easy to use. Merged that function into the branch.

srs81 commented 12 years ago

Thank you for your contribution! This is perfect! Are you able to test that this works on IE/Chrome/Firefox? I'll merge if you can confirm? (I can only test on Chrome/Firefox, not IE unfortunately.)

plugs commented 12 years ago

Tested with IE9 (IE7+IE8 Mode), Chrome & Firefox - works fine! IE9 only emulates IE7+IE8, I'll test ist tomorrow with VMs too to be 100% sure.

srs81 commented 12 years ago

Fantastic! Thanks so much! I've merged the changes. This is what makes open source work. :)