search

srsabu / practicesharp

Automatically exported from code.google.com/p/practicesharp
0 stars 0 forks source link

1.62 Large position change freezes PracticeSharp #12

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Anything but the slightest change in position locks up PS and requires a Task 
Manager "End Process". This worked in 1.41, now does not work in 1.62. (tested 
with 5 various MP3s and 2 FLACs, always locks up)

Original issue reported on code.google.com by kzinn...@gmail.com on 12 Mar 2013 at 2:49

GoogleCodeExporter commented 9 years ago 
This issue is troubling me for some time, and I've noticed it on some machines 
but not on all.
It seems that Practice# has a dead lock.
I was able to replicate it on one machine on version 1.6.1 and fix it, but I'm 
afraid the fix did not hold for your machine.

First, could you describe exactly how you make a position change? Using a mouse 
or using the keyboard? When you do that, is the speed X1.0 or other values? I'm 
trying to isolate the problem, to make sure it is not some other feature.

If you could debug Practice# 1.6.2 on your machine, and let me know where the 
dead lock happens (where the code is stuck, when you pause the program when 
that freeze happens) it could confirm the dead lock position.

I'm considering this a high priority defect, and must fix it before the next 
release.

Original comment by yuva...@gmail.com on 12 Mar 2013 at 10:02

GoogleCodeExporter commented 9 years ago 
I changed the source code in Version 1.6.3.
I think I found the dead lock issue.I suspect that manipulating NAudio inside 
lock blocks, combined with NAudio events, caused that dead lock.
I now have another lock, and the lock blocks are much shorter without actual 
logic in them, just variable assignment. 
Will test a little more and commit later on.

Original comment by yuva...@gmail.com on 12 Mar 2013 at 2:00

GoogleCodeExporter commented 9 years ago

Original comment by yuva...@gmail.com on 21 Mar 2013 at 1:31

GoogleCodeExporter commented 9 years ago 
Agreed that this is fixed, and btw I like the way the selector looks and works. 
I really gave the position change function a workout on a number of different 
audio files  and nothing locks up.

Original comment by kzinn...@gmail.com on 21 Mar 2013 at 2:02

GoogleCodeExporter commented 9 years ago 
@kzinnato
Thanks for your QA help! Much appreciated.

Original comment by yuva...@gmail.com on 21 Mar 2013 at 1:53