search

srsholmes / yal

Yet Another Launcher
272 stars 6 forks source link

fix: enable ts strict mode, prevent error when no plugins are installed #2

Closed luckydye closed 1 year ago

luckydye commented 1 year ago

I think it would be a good idea to use strict mode to ensure code quality and prevent bugs (such as in third-party-plugins.ts) going forward. :)

This change will make some existing type errors appear in the codebase though.

srsholmes commented 1 year ago

Hello. Thanks for the PR. I ran a TS check with strict mode on and it went from 2 errors to 169.

To be honest I thought strict mode was on all this time, so this is a great catch. Usually I work with strict mode.

I'm going to try and fix up these errors as a first priority after merging.

I am going to try to keep TS errors down to a minimum after merging this, and stay to a stricter branching strategy.