Closed DanielTsiang closed 5 months ago
Might want to hold off merging this PR in actually until this bug is resolved:
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
a7b8f57
) 99.46% compared to head (4b71789
) 99.46%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks, @DanielTsiang, this makes things clearer! I've added a commit to give more detailed instructions about avoiding the issue you experienced in #255. Note I reverted your change to the nb-clean 1.6.0
column in the migration table: in 1.6.0, the notebook path was passed with the --input
flag and not as a positional argument, so can't be moved to the end of the command line.
Thanks for correcting the PR!
The README.md is a lot clearer now so hopefully a lot more people will feel comfortable using this tool in the future! 🙂
Make README.md clearer.
Changes:
nb-clean
in the CI and you're piping notebook filenames to the command viaxargs
.