Closed jamesbraza closed 7 months ago
I'm not eager to add configuration file parsing because of the additional complexity it would bring (such as dealing with overrides from command line arguments), especially as this is not a codebase I work on regularly. You can run the pre-commit hook manually with pre-commit run nb-clean --all-files
; does that suffice for your use case?
Yeah that's a fine workaround, so feel free to close this out.
I will say though, it's not a big lift. CLI args always override the associated config file entry, and this simple conditional logic would live outside of the core of nb-clean
.
I currently use
nb-clean
in mypre-commit
config like so:It would be nice if the
args
could be moved to apyproject.toml
, so that runningnb-clean clean
locally (outside ofpre-commit
) could also use the same configuration.