search

srsudar / eg

Useful examples at the command line.
MIT License
1.8k stars 99 forks source link

Add ip command #46

Closed Sispheor closed 8 years ago

Sispheor commented 8 years ago

Everything is in the title ;)

srsudar commented 8 years ago

Thanks! I'll work on merging this and the other PR starting at the end of next week.

scorphus commented 8 years ago

@Sispheor Thanks a lot for you contribution! I have some line comments, though.

scorphus commented 8 years ago

Also, would you please squash the commits into a single one?

Sispheor commented 8 years ago

Should be ok now

scorphus commented 8 years ago

Oh. Actually, not quite. Below is how the tree looks now (click here for the Git alias that generated the following):

clip

If you'd like, and allow me, I can record an asciinema while I fix both branches, amending/squashing your commits and commenting as I do it.

Then, if you grant me write permission to your Sispheor/eg repository, I can fix the pull requests as well. It's like an image/video is worth many words :relaxed:

Sispheor commented 8 years ago

I've added you as collaborator on my project.

2015-11-17 0:11 GMT+01:00 Pablo Aguiar notifications@github.com:

Oh. Actually, not quite. Below is how the tree looks now (click here https://github.com/scorphus/dotfilesetal/blob/master/.gitconfig#L49 for the Git alias that generated the following):

[image: clip] https://cloud.githubusercontent.com/assets/2112697/11197475/de158dac-8ca4-11e5-801f-d0eb4a66a870.png

If you'd like, and allow me, I can record an asciinema http://asciinema.org while I fix both branches, amending/squashing your commits and commenting as I do it.

Then, if you grant me write permission to your Sispheor/eg repository, I can fix the pull requests as well. It's like an image/video is worth many words [image: :relaxed:]

— Reply to this email directly or view it on GitHub https://github.com/srsudar/eg/pull/46#issuecomment-157204359.

Nicolas MARCQ

scorphus commented 8 years ago

@Sispheor I've updated the branch add_ip_command which is the result of the following recorded terminal session:

asciicast

I hope it's helpful :smiley:

I'll soon update the add_git_command branch too, but with a different approach.

Sispheor commented 8 years ago

Thank you for the job. And for the Git lesson! ;)

2015-11-17 16:18 GMT+01:00 Pablo Aguiar notifications@github.com:

@Sispheor https://github.com/Sispheor I've updated the branch add_ip_command which is the result of the following recorded terminal session:

[image: asciicast] https://asciinema.org/a/216bruwcrq5s3x1ctyeewv5n5

I hope it's helpful [image: :smiley:]

I'll soon update the add_git_command branch too, but with a different approach.

— Reply to this email directly or view it on GitHub https://github.com/srsudar/eg/pull/46#issuecomment-157400754.

Nicolas MARCQ

scorphus commented 8 years ago

Thank you for the job. And for the Git lesson! ;)

My pleasure! I'm glad it helped even if a bit :blush: