search

srtfisher / Lockdown-WPAdmin

WordPress Plugin to hide login and admin URLs when not logged into WordPress.
http://wordpress.org/plugins/lockdown-wp-admin/
47 stars 15 forks source link

Reduce init priority to 20 #7

Closed jessepollak closed 10 years ago

jessepollak commented 10 years ago

I'm one of the developers of Clef. We've had bug reports (clef/wordpress#120) that Clef doesn't show up when users are using Lockdown-WP-Admin to hide their login page.

I did some digging and it looks like this is because we're both using the default priority of 10 for the init action. Because of randomness, Lockdown-WPAdmin gets initialized before Clef, and includes the wp-login.php file before we have the time to hook into it.

There could be an argument made for both of us moving our priority forward or backward, but after some thinking I actually think it makes the most sense for Lockdown-WPAdmin to. After doing some research, there are other login plugins that hook at this time — which are excluded from use with the current Lockdown-WPAdmin priority. Delaying y'alls hook to 20 (or 99) will allow more functionality which should be on the login page to actually be there.

What do you think?

srtfisher commented 10 years ago

No worries here!

jessepollak commented 10 years ago

Thanks! Would you mind releasing an update to the plugin with the change?