search

srtucker22 / chatty

A WhatsApp clone with React Native and Apollo (Tutorial)
https://medium.com/@simontucker/building-chatty-a-whatsapp-clone-with-react-native-and-apollo-part-1-setup-68a02f7e11
MIT License
500 stars 110 forks source link

Fix input styles #25

Closed alecperkey closed 6 years ago

srtucker22 commented 6 years ago

Hey @alecperkey

Thanks for checkout out chatty and submitting a PR! Just wanna warn outright that the organization of chatty is very weird due to its reliance on tortilla and makes it difficult for outside contributors to submit PRs.

Can you tell me a little bit about this PR and what it's trying to accomplish? What are some of the features you've added, bugs you've identified and fixed, etc?

Also, some of your sensitive data is showing. I would suggest (1) changing your credentials/keys on those platforms and (2) removing commits with the sensitive data -- it's not enough to overwrite in a new commit

🍺

alecperkey commented 6 years ago

Ahaha woops, github always defaults to point at the original (your repo) when I push a feature branch intending to merge with my fork. Must have missed this time. I caught some of my aws/firebase keys and git ignored/ removed/rotated them. Will double check.

Side note, I really appreciate the headstart learning your work here has given me.

I'm working on updating fcm push notifications and Amazon file uploads this weekend. Then swapping in postgresql (and learning other things necessary for production).

You can close or delete this pr

On Jan 19, 2018 9:58 AM, "Simon Tucker" notifications@github.com wrote:

Hey @alecperkey https://github.com/alecperkey

Thanks for checkout out chatty and submitting a PR! Just wanna warn outright that the organization of chatty is very weird due to its reliance on tortilla https://github.com/Urigo/tortilla and makes it difficult for outside contributors to submit PRs.

Can you tell me a little bit about this PR and what it's trying to accomplish? What are some of the features you've added, bugs you've identified and fixed, etc?

Also, some of your sensitive data is showing. I would suggest (1) changing your credentials/keys on those platforms and (2) removing commits with the sensitive data https://help.github.com/articles/removing-sensitive-data-from-a-repository/ -- it's not enough to overwrite in a new commit

🍺

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/srtucker22/chatty/pull/25#issuecomment-359042517, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLv0SvAWmXlTa4vVuNmLUdJlfOezHvhks5tMNfFgaJpZM4RfILe .

srtucker22 commented 6 years ago

No worries. Glad it was helpful!