srush / Triton-Puzzles

Puzzles for learning Triton
Apache License 2.0
925 stars 57 forks source link

fix: The tests for Puzzle 5 should fail unless the ReLU is implemented #4

Closed xffxff closed 4 months ago

xffxff commented 5 months ago

Since the task for Puzzle 5 requires implementing relu(x * y) and both inputs x and y are positive, resulting in a positive product, the tests will pass even without an actual implementation of relu. This PR modifies a single line, as shown below, to ensure that the inputs x and y include both positive and negative numbers

image