srush / Triton-Puzzles

Puzzles for learning Triton
Apache License 2.0
925 stars 57 forks source link

[Temp fix] Revert triton-viz version to use old version for triton, hash 62cb630 #5

Closed lbertge closed 4 months ago

lbertge commented 4 months ago

(This is mostly for Colab usage)

The Colab notebook stopped working for me sometime this afternoon. In the third code cell, I was getting errors of the formcannot import name 'interpreter_builder' from 'triton.runtime.interpreter' when trying to import the triton_viz library.

I was able to cross-match this timing with commits in the triton-viz library (https://github.com/Deep-Learning-Profiling-Tools/triton-viz/commit/65a0ef4412183f0b17426a2007fb3a7f310503f8). I made a change which installs a slightly older version of triton-viz, and this seems to work for now.

In discord, @Jokeren was recommending to rebuild triton from source, but unfortunately this doesn't seem to cooperate well with Colab (something goes wrong when running pip install -e python). Open to other fixes, I just thought this was the simplest to implement.

srush commented 4 months ago

The latest version should work now. I pushed a fix.

lbertge commented 4 months ago

thank you!