srush / annotated-s4

Implementation of https://srush.github.io/annotated-s4
https://srush.github.io/annotated-s4
MIT License
468 stars 60 forks source link

Add CIFAR-10 Classification Results #17

Closed siddk closed 2 years ago

siddk commented 2 years ago

Add pipeline for CIFAR-10 Classification, as well as smoothing out training loop kinks. Additionally updates some of the exposition in the literate s4.py implementation.

Making a Draft PR because current code fails to replicate results in original S4 codebase. Running apples-to-apples (or as close as possible) results in ~66% accuracy (vs. 89% reported).

Possible reasons:

Resolves #8

siddk commented 2 years ago

Merge CIFAR --> just folded in the Optimization commits.

siddk commented 2 years ago

Updated results, run command is here.

Resolves #8

siddk commented 2 years ago

@srush - right now the replication command is just in the README; do we want to get rid of the unnecessary (other hyperparameter) runs?

srush commented 2 years ago

Yes, think we should clean up the readme to the working commands.

siddk commented 2 years ago

Done