srush / annotated-s4

Implementation of https://srush.github.io/annotated-s4
https://srush.github.io/annotated-s4
MIT License
468 stars 60 forks source link

Simplify and test the training code #2

Closed srush closed 2 years ago

srush commented 2 years ago

Going through my journey of learning Flax, updated some of the code for training.

Changes:

I haven't updated the comments yet or literate aspects yet.

siddk commented 2 years ago

This makes sense to me - didn't follow the use of @partial(np.vectorize) at first, might be worth a comment.

I'm running into some relative import errors when I try to run the code in this PR, will fix, and push... ideally hold of on merging until then!