search

srush / annotated-s4

Implementation of https://srush.github.io/annotated-s4
https://srush.github.io/annotated-s4
MIT License
468 stars 60 forks source link

S4 Edits v2 #32

Closed siddk closed 2 years ago

siddk commented 2 years ago

Mostly line edits, getting code to fit within display boxes, grammar/typos.

srush commented 2 years ago

Looks good, but linter is failing.

Maybe the : should be , ? That might be my weird spelling quirk.

siddk commented 2 years ago

Linter is failing because of one line of code that in the blog post goes over the "display block" but the linter thinks should be formatted as one line.

I can totally change : to , -- that's just my weird spelling quirk haha.

srush commented 2 years ago

Yeah, lets go with ",". Otherwise should we call it done?

siddk commented 2 years ago

Ok - issue was that I configured the linter incorrectly - my bad! @srush - colons or commas?

srush commented 2 years ago

oops, think we crossed. Let's do commas

siddk commented 2 years ago

Commas have landed - ready to ship!

siddk commented 2 years ago

Think we crossed again - I think this is ready to merge?