added z-transform suggestion to the text

srush / annotated-s4

Implementation of https://srush.github.io/annotated-s4

https://srush.github.io/annotated-s4

MIT License

460 stars 61 forks source link

added z-transform suggestion to the text #47

Closed ekinakyurek closed 2 years ago

ekinakyurek commented 2 years ago

Hi @srush @siddk,

I added a clarification point to the generating function part above the conv_from_gen function. I also removed the re-ordering by evualating generating function at minus the roots of the unity. It reads me better now as a person coming from electrical engineering background. I hope it can be helpful for others as well.

Best Ekin

srush commented 2 years ago

Thanks, I agree this makes things simpler. Please let us know if there are any other changes that you would recommend!