srush / annotated-s4

Implementation of https://srush.github.io/annotated-s4
https://srush.github.io/annotated-s4
MIT License
460 stars 61 forks source link

typos in blog #54

Closed qsh-zh closed 2 years ago

qsh-zh commented 2 years ago

Thanks for your awesome blogs,

I notice there may be some typos in the blog,

  1. image

The term $q^p$ should be $q^ \Gamma^{-1}p$.

  1. image If we follow the assumption that $A=\Gamma - p^q$ the $1-k_{z,\Gamma}(q^, p)$ should be $1+k_{z,\Gamma}(q^*, p)$.

  2. (may be not a typo) image The decomposition for $A$ should be $\Gamma - p^q$ (maybe authors want to use $\Gamma + p^q$ for the introduction of Woodbury.

srush commented 2 years ago

Thanks. Yes, these are incorrect. Will update.