srush / annotated-s4

Implementation of https://srush.github.io/annotated-s4
https://srush.github.io/annotated-s4
MIT License
460 stars 61 forks source link

Edit pass on DSS #57

Closed srush closed 2 years ago

srush commented 2 years ago

I went through part 1 which I think is relatively clear.

I got a bit confused in part 2. I might need to read it a bit more closely.

Unless you think it is necessary, I'm not sure we need to put in all the proofs. If we do it might be nice to have the code aligned with them? I feel like that is the value added that we provide to the readers.