search

srush / annotated-s4

Implementation of https://srush.github.io/annotated-s4
https://srush.github.io/annotated-s4
MIT License
460 stars 61 forks source link

Major update to models #60

Closed albertfgu closed 2 years ago

albertfgu commented 2 years ago

This PR comprises PRs 1-15 of my fork https://github.com/albertfgu/annotated-s4/pulls

srush commented 2 years ago

I'm going to accept this and render as a v3.

NB: I haven't yet read the S4D post, but given that it is non-breaking, I will just merge this, and we can go from there.