search

srushti / goldberg

Goldberg is a lightweight CI server written in Ruby which worries about Bundler & RVM so that you don't have to.
Other
243 stars 29 forks source link

Displaying author for the checkin that broke the build issue #92 #104

Closed suryagaddipati closed 12 years ago

srushti commented 13 years ago

Looks pretty good. One thing I'd like is to list all the people who have committed to that specific build, not just the very last committer. Any of those commits could have failed the build.

suryagaddipati commented 13 years ago

@srushti ha, yes I agree. Let me see how i could get that in.

suryagaddipati commented 12 years ago

@srushti i took a shot a displaying all the authors who might have caused the build to fail. Could you take a look.

srushti commented 12 years ago

@suryagaddipati I took a look, and I was looking for a clarification. You seem to have handled the problem where the build has broken multiple times, with different committers. Does it handle the issue where there are multiple committers on one single build? At first glance it doesn't look like it. If you tell me it does, I'll look at it more closely.

suryagaddipati commented 12 years ago

@srushti yes it does. I just realized that the method should have been called "revision_range" instead or "build_range". Let me rename the method and submit it.

srushti commented 12 years ago

Is there any progress on this? If not, I'm happy to pick up the last bit and finish it. Let me know either way.

suryagaddipati commented 12 years ago

@srushti I was out on vacation. will submit it in a day or two.

srushti commented 12 years ago

Sure, no problem. Just let me know if you won't be working on it, and I can pick it up.

suryagaddipati commented 12 years ago

I've changed the the method name to match what its doing. Please take a look and let me know what you think.

srushti commented 12 years ago

Thanks. It's been merged in. I haven't had a chance to test it yet, but I'm assuming it's fine.