srushti / goldberg

Goldberg is a lightweight CI server written in Ruby which worries about Bundler & RVM so that you don't have to.
Other
243 stars 29 forks source link

The test.log for any build should be treated as a build artifact #115

Open kaiwren opened 12 years ago

kaiwren commented 12 years ago

The Rails test.log for a particular build is a useful build artifact that should be easy to examine in isolation.

srushti commented 12 years ago

Sure. But, are you suggesting that we do special things for rails projects? Thus far we haven't done anything Rails-specific, and this would be a change from that.

kaiwren commented 12 years ago

Not really - I'd just like to be able to specify that these files generated by the build are build artifacts. The rails log would be no different from an rcov coverage report or a .net setup.exe.

srushti commented 12 years ago

Okay, but we can do that already. You just have to copy these files to ENV['BUILD_ARTEFACTS']. We're already doing this for simplecov report for goldberg. https://github.com/c42/goldberg/blob/master/lib/tasks/ci.rake#L3 Am I missing something?

kaiwren commented 12 years ago

The same test.log is being written to continuously. Perhaps a recipe in the docs for a rake task that truncates the log file in a rails project before the build and copies it over after? Also, we'd need to document ENV['BUILD_ARTEFACTS'].