Raise visible errors when Git pull fails

srushti / goldberg

Goldberg is a lightweight CI server written in Ruby which worries about Bundler & RVM so that you don't have to.

Other

243 stars 29 forks source link

Raise visible errors when Git pull fails #128

Closed jasim closed 5 years ago

jasim commented 12 years ago

Goldberg does not run any build if Git pull fails. There is no notification so it is hard to figure out what went wrong.

A typical case where this happens is:
schema.rb is checked in. A new commit is made which has a migration; but this commit does not check in the updated schema.rb. Goldberg will at this point run the migration which will create a locally modified version (in the CI server) of the schema.rb. Next time Goldberg tries to pull - the conflict in schema.rb will cause it to fail.

srushti commented 11 years ago

The git pull issue specifically has been fixed since we do a hard reset before pulling now. But, this probably should still be done to account for scenarios where the version control server is not reachable (or other similar error).