Issue #135 and Fixed errors in Last pull request #137

srushti / goldberg

Goldberg is a lightweight CI server written in Ruby which worries about Bundler & RVM so that you don't have to.

Other

243 stars 29 forks source link

Issue #135 and Fixed errors in Last pull request #137 #138

Closed pahnin closed 11 years ago

pahnin commented 12 years ago

Please see the commit message https://github.com/pahnin/goldberg/commit/82916daa839c9f0e539f558b3a4c1626807c7435

pahnin commented 12 years ago

any problem with this pull-request?

srushti commented 11 years ago

Everything looks fine and I'll merge it in today, and identify more stories for you to work on. In the future, I'd suggest you make these changes and raise pull requests from a branch. Project timelines (me included) tend to squash commits to clean up their timeline & maybe even rebase. As it stands, once I merge it you will probably have to delete your app and reclone or at least delete master and recreate it.

pahnin commented 11 years ago

Ok. Thanks.

srushti commented 11 years ago

Merged (93f78ada5e0eadece9fabc1b49082dfb2d4e0518).