srushti / goldberg

Goldberg is a lightweight CI server written in Ruby which worries about Bundler & RVM so that you don't have to.
Other
243 stars 29 forks source link

suggestion: making running more complex build commands easier #146

Closed ghost closed 11 years ago

ghost commented 11 years ago

Again, I'm not 100% sure about the following, if it should be adopted or not, but it made specifying more complex build commands easier, for me:

--- orangenschale.orig/app/models/build.rb  2012-07-12 05:14:44.000000000 -0500
+++ orangenschale/app/models/build.rb   2012-07-16 05:52:38.974186100 -0500
@@ -46,7 +46,7 @@
   def run
     before_build
     Bundler.with_clean_env do
-      build_command = "script/goldberg-build '#{project.name}' '#{ruby}' '#{project.code_path}' '#{build_log_path}' '#{artefacts_path}' '#{project.nice}' '#{environment_string}' '#{project.bundler_options}' #{project.build_command}"
+      build_command = "script/goldberg-build '#{project.name}' '#{ruby}' '#{project.code_path}' '#{build_log_path}' '#{artefacts_path}' '#{project.nice}' '#{environment_string}' '#{project.bundler_options}' '#{project.build_command}'"
       execute_async(build_command)
     end
   end
srushti commented 11 years ago

Sorry, what's the difference here? The quotes around the build command?

ghost commented 11 years ago

yes

srushti commented 11 years ago

I don't want to add any quotes here which might interfere with quotes people might add within the build_command itself. I think I'd rather leave it to people on whether they wish to use quotes or not. Thanks anyway.

ghost commented 11 years ago

yes, you are right, I didn't think of that...