search

srushti / goldberg

Goldberg is a lightweight CI server written in Ruby which worries about Bundler & RVM so that you don't have to.
Other
243 stars 29 forks source link

Bug fix and some documentation comments #33

Closed professor closed 13 years ago

professor commented 13 years ago

1 - Bug fix: a project name could contain spaces when executed on the command line, ie bin/goldberg add 'My Project'" -- I inserted the code on Project.

I added a spec and then got the code to work

2 - spelling change

3 - Added location of project directories to readme file

BTW, when I do the pull request, I'm using my "professor" github account, yet when the code is merged into your mainline repository it shows up as "cmusv" which is one of my organizations. Ironically this isn't associated with my repo. Any ideas on why this happens?

professor commented 13 years ago

Do you want to submit the documentation changes as a separate pull request?

srushti commented 13 years ago

The problem seems to be the place where we do some string replacement to do a "git clone". Could you fix it so it escapes the name on cloning (and while cding before running a build)? If not, I'd rather fail and inform the user that we can't accept project names with spaces, so she can decide whether to use underscores, or make it one word or whatever, and we can eventually fix it somewhere down the line.

professor commented 13 years ago

Since the commander code is coming today or tomorrow, I'll close this pull request and submit the documentation updates as a separate git request