search

srushti / goldberg

Goldberg is a lightweight CI server written in Ruby which worries about Bundler & RVM so that you don't have to.
Other
242 stars 29 forks source link

Goldberg start command now daemonizes. Added stop command. #35

Closed drewolson closed 13 years ago

drewolson commented 13 years ago

I updated the goldberg start command to daemonize the process using the rackup -D flag and write a pid file using the rackup -P flag. I also added a goldberg stop command which kills the daemonized process using the pid file.

Hope you like what you see!

srushti commented 13 years ago

Looks good. We've moved to using the commander gem to hand the command-line options. Could you merge latest (moving 'stop' to the new 'bin/goldberg', of course) and give us another pull request.

kaiwren commented 13 years ago

@srushti Checking in to the branch against which this pull request was created updates the pull request, so you don't have to create a new one.

drewolson commented 13 years ago

I've rebased my master on your latest master and updated my stop command to use commander. Let me know if any other changes are needed before pulling this in.

Thanks, Drew

srushti commented 13 years ago

Thanks. I've merged in the changes. I haven't tested this extensively, but it looks good for now.