I wanted the "builds" page to look more like the "projects" dashboard page with respect to colors. I'd like to quickly see which builds have been passing vs failing via colors.
I started to do my treatment on the "builds" page but I came across some obstacles that are probably faster for you to solve since you know the original code base better than me.
a) the html construct of the project page is table with
, the html construct of the build list is a list with
b) it wasn't clear to me if you wanted one css file for the entire project, or one css file for each view.
My suggestion is to rewrite the code that generate the builds list (ie the
) and convert it into a table structure like the project page. It's almost midnight here and I don't trust my coding skills at this point. =)
Actually, I would rather go the other way, and get rid of the table on the dashboard. Generally, table (actually any markup which specifies layout) is discouraged. Hence, we have over & over . We were just being lazy with home page and made it a table.
Whether you use li or table cells isn't that important to me. I think the two pages are similar and should look the same when you list out either build status or project status.
Yes, in the past developers used tables to do layout, I find that the pendulum swings the other way and people don't want to use table cells at all. I find they are helpful when displaying tabular data. This appears to be tabular data, yet again, I don't really care which tags are used.
Like I said it's more of a general issue with only having semantic-y stuff in html & leaving all styling & layout stuff to css. Anyway, a basic version of this has now been implemented, and i'm closing this issue.
I wanted the "builds" page to look more like the "projects" dashboard page with respect to colors. I'd like to quickly see which builds have been passing vs failing via colors.
I started to do my treatment on the "builds" page but I came across some obstacles that are probably faster for you to solve since you know the original code base better than me.
a) the html construct of the project page is table with
b) it wasn't clear to me if you wanted one css file for the entire project, or one css file for each view.
My suggestion is to rewrite the code that generate the builds list (ie the
Actually, I would rather go the other way, and get rid of the table on the dashboard. Generally, table (actually any markup which specifies layout) is discouraged. Hence, we have over & over . We were just being lazy with home page and made it a table.
Whether you use li or table cells isn't that important to me. I think the two pages are similar and should look the same when you list out either build status or project status.
Yes, in the past developers used tables to do layout, I find that the pendulum swings the other way and people don't want to use table cells at all. I find they are helpful when displaying tabular data. This appears to be tabular data, yet again, I don't really care which tags are used.
Like I said it's more of a general issue with only having semantic-y stuff in html & leaving all styling & layout stuff to css. Anyway, a basic version of this has now been implemented, and i'm closing this issue.