search

srushti / goldberg

Goldberg is a lightweight CI server written in Ruby which worries about Bundler & RVM so that you don't have to.
Other
243 stars 29 forks source link

Support for RVM custom location #79

Closed lucasefe closed 13 years ago

lucasefe commented 13 years ago

I have installed rvm into /usr/local/rvm, so the build process is not working. Reviewing the RVM class I saw a hardcoded value for the RVM path. I think this should be customizable.

Thanks!

Lucas Florio

lucasefe commented 13 years ago

BTW, if I symlink my rvm folder to $HOME/.rvm, the build seems to work.

srushti commented 13 years ago

Good catch. We'll work on this immediately. None of us have system rvm installed and so it didn't occur to us to make this configurable.

lucasefe commented 13 years ago

I have something working on my fork.

https://github.com/lucasefe/goldberg/blob/master/app/models/rvm.rb

Tell if this is good enough for you, so I will do a Pull Request.

Cheers

srushti commented 13 years ago

Thanks, I've merged in the changes. I noticed one thing which I was curious about. The system script path didn't include the root directory ('usr/local/rvm/scripts/rvm'). Does that work fine for you? I've added a '/' to the beginning, and also expanded the tests to work with the system rvm as well. Let me know if it works fine, and I'll close this ticket.

lucasefe commented 13 years ago

Cool! Regarding the path, let me tell you that I did not have a chance to test it, because I was still having problems starting up Goldberg with passenger 3.0.7 (there's a ticket for this too). So your correction is right. The / slash was needed.

Thanks.