search

srushti / goldberg

Goldberg is a lightweight CI server written in Ruby which worries about Bundler & RVM so that you don't have to.
Other
242 stars 29 forks source link

SVN support #87

Closed suryagaddipati closed 13 years ago

suryagaddipati commented 13 years ago

Had to add Svn support to make it work with our repos at work

srushti commented 13 years ago

Thanks, but I don't think we can decide on the scm being used based on the beginning of the url. We can't be sure that git projects are using the git protocol, or that the user used in ssh is git. It could be added over http or the user for ssh could be something else. We'll need some other mechanism to branch the logic.

suryagaddipati commented 13 years ago

@srushti Agree the implementation was pretty naive to assume that git repos start with 'git'. was mostly meant as first pass. @kaiwren yes there is no foolproof way to guess what kind of scm it is from the url. I agree that git should be the default if no scm is specified while adding the repo. Will make that change.

kaiwren commented 13 years ago

Let me know if you're pressed for time - I'm happy to merge your changes to my local branch and proceed with adding the CLI components.

suryagaddipati commented 13 years ago

@kaiwren thanks I had made some progress on it i will should be done with it in a few.