srusskih / SublimeJEDI

awesome Python autocompletion with SublimeText
MIT License
938 stars 109 forks source link

Update completion behavior #244

Closed srusskih closed 6 years ago

srusskih commented 6 years ago
edelvalle commented 6 years ago

I will try this, and give you some feedback

srusskih commented 6 years ago

@edelvalle thanks

srusskih commented 6 years ago

@edelvalle due to I did lots of changes in utils.py and daemon.py i had to re-apply your's changes from #246. could you please review if I did it right?

edelvalle commented 6 years ago

Using goto definition fails...

Traceback (most recent call last):
  File "/home/xigurat/.config/sublime-text-3/Packages/Jedi - Python autocompletion/sublime_jedi/daemon.py", line 93, in _async_summon
    run_in_active_view(window_id)(callback)(answer)
  File "/home/xigurat/.config/sublime-text-3/Packages/Jedi - Python autocompletion/sublime_jedi/daemon.py", line 109, in _wrapper
    return func(window.active_view(), *args, **kwargs)
  File "/home/xigurat/.config/sublime-text-3/Packages/Jedi - Python autocompletion/sublime_jedi/go_to.py", line 143, in handle_definitions
    self._jump_to_in_window(*defn)
  File "/home/xigurat/.config/sublime-text-3/Packages/Jedi - Python autocompletion/sublime_jedi/go_to.py", line 42, in _jump_to_in_window
    flags = self.prepare_layout(active_window, transient, filename)
  File "/home/xigurat/.config/sublime-text-3/Packages/Jedi - Python autocompletion/sublime_jedi/go_to.py", line 58, in prepare_layout
    goto_layout = get_settings_param(self.view, 'sublime_goto_layout')
NameError: global name 'get_settings_param' is not defined
edelvalle commented 6 years ago

254 Fixes this, but don't merge yet. I still evaluating...

edelvalle commented 6 years ago

This is ready, I had no problems with it for the past weeks! Thanks!

srusskih commented 6 years ago

@edelvalle thanks for testing session! ⭐️