search

srusskih / SublimeJEDI

awesome Python autocompletion with SublimeText
MIT License
938 stars 109 forks source link

Add `follow_imports` option. #246

Closed edelvalle closed 6 years ago

edelvalle commented 6 years ago

So right now in the go to functionality, if you have something like.

from blabla import Xxx

x = Xxx()

And you are in the last like and you try "go to definition" over Xxx this thing just goes to the import on the top of the file, and does not follow that import to the actual definition of Xxx; and I find that kind of annoying because takes me out of my context, does not go to Xxx and I have to hit "go to definition" again, and pray that the module blabla does not have Xxx as an import also.

So in the past jedi use to work with follow_imports=True by default, and a few months ago it changed. So, this PR makes the default behavior "go the the actual definition" and allows the user to configure to not follow the imports.

edelvalle commented 6 years ago

WTF, why It adds so many commits? Was just one...?

srusskih commented 6 years ago

Could you please add information to README?

edelvalle commented 6 years ago

@srusskih Did the updates you asked for, sorry for the delay ;)

edelvalle commented 6 years ago

The commit "Allow passing parameters to daemon requests" opens the door to send a lot of configuration directly to request and not pre-load it with the daemon

srusskih commented 6 years ago

@edelvalle thanks a lot!