Update jedi to v0.13.1

[magnetikonline]

Change to update Jedi package to v0.13.1.

Note: this does cause an issue, where Jedi has now dropped support for Python 3.3 - so had to patch access.py here and here.

• Can only assume that SublimeText 3 comes packaged with an earlier point release of Python 3?
• Technically this does also mean the Makefile won't work as is without patching of the jedi package.

Otherwise, all good.

[edelvalle]

I kind of like this approach until Sublime upgrades its Python interpreter but I suggest to do it in a way that is easy to maintain.

Let's make a fork of Jedi and apply there the patch for Python 3.3 compatibility and let's point the make file there. As long we Sublime has this old Python we maintain our fork and when it upgrades then we delete it and repoint the Makefile.

What about that? @srusskih

[magnetikonline]

That's not a bad idea @edelvalle - the only alternative I guess is produce a patch file from the mainline to the version I've constructed and roll that into the Makefile (download mainline, apply patch).

Regardless, it's working well this branch for me - sure there is some solution worth doing. 👍

[srusskih]

Thanks! Great job! I have couple questions:

• https://github.com/davidhalter/jedi/pull/1019/files#diff-8bb3cd6a401ec9f9abb26c380f7878e4L154 find_module = find_module_py33 if is_py33 else find_module_pre_py33 how about this ?

• types.DynamicClassAttribute was used for Python >=3.4. Now, in the path, It applies only for >=3.5. can it be an issue for Python 3.4 users?

• https://github.com/davidhalter/jedi/blob/master/CHANGELOG.rst#0130-2018-10-02

  Default environments are now using the same Python version as the Python process. In 0.12.x, we used to load the latest Python version on the system. if no setting provided, will it fails on SublimeText's Python?

Could you please create a patch-file and add include it PR?

[magnetikonline]

Well spotted @srusskih - I'll grep the new version of Jedi and find any other instances of is_py34/etc. that might be of concern.

Along with those other concerns + a patch.

I guess you're thinking we then exec. said patch from Makefile?

[srusskih]

@magnetikonline Thanks a lot! 👍

[magnetikonline]

No dramas @srusskih - a bit flat out with other items at the moment, but it's on my todo list! Using SL Jedi in anger the last week with this patched branch, it's been working really well.

[magnetikonline]

Just rebased master in here. Sorry, still finding time to round this out!

[srusskih]

I hope complete it during next couple weeks, have started https://github.com/srusskih/SublimeJEDI/tree/jedi-0.13.x

have to update daemon.py also :(

[srusskih]

@magnetikonline just updated daemon.py - please try, if it works for you. thanks :)

[edelvalle]

I'm testing, seems to be ok... Tomorrow will use it the whole day.... let's see

[srusskih]

@edelvalle thank you

[magnetikonline]

Nice work @srusskih - I'll switch branches now for today..... will report back!

[magnetikonline]

Just noted 0.13.2 released of Jedi.

https://github.com/davidhalter/jedi/releases/tag/v0.13.2

[magnetikonline]

Also @srusskih the new branch is running very solid! 👍

[edelvalle]

I can confirm too... working all good!

[magnetikonline]

I've just merged in https://github.com/davidhalter/jedi/releases/tag/v0.13.2 to my branch to give that a test - also including your changes too from your https://github.com/srusskih/SublimeJEDI/tree/jedi-0.13.x branch.

What 0.13.2 adds: https://github.com/magnetikonline/SublimeJEDI/commit/afa386ed302bbb3988865e934b725d73ef2b8b87

[magnetikonline]

Been successfully running 0.13.2 for the last day in branch above ☝️ @srusskih I'd say it's safe to merge in those Jedi upstream release changes into your branch.

[srusskih]

@magnetikonline I think we can merge your PR, If you do not mind.

[magnetikonline]

@srusskih let's do it. All running solid here.

Edit: Just cleaned up commit messages 👇

[magnetikonline]

Argh! Left out your .patch file... trying again.

Edit: ....and, that's better - build now passing!