search

srusskih / SublimeJEDI

awesome Python autocompletion with SublimeText
MIT License
938 stars 109 forks source link

Re-Enable default goto popup #319

Closed nixxo closed 3 years ago

nixxo commented 3 years ago

This modification re-enables the default goto popup when "enable_tooltip" is set to false.

In this moment jedi only sets the "show_definitions" setting to False when "enable_tooltip" is True but it never reset it back when you set it to False causing the default popup to never show up ever again (you have to enable it manually)

srusskih commented 3 years ago

Wow! Thanks a lot 👍

nixxo commented 3 years ago

no problem. Happy to contribute.

andy0130tw commented 4 weeks ago

I am afraid that this makes conflicts with the preference option that is specified by either the user or another plugin. A scenario is that one has an LSP plugin that maintain its own hover popups, and always sets this option to false upon switching to the view it manages, and there would be a race condition. Perhaps you need to remember the old setting and restore it in this case, instead of setting it to true?