Closed Aryamanz29 closed 3 years ago
@sruti2024 @SaiSudhaV @PROTechThor Need Review for this PR 📝
@Aryamanz29 There are some files that still have inline styling. Can't they be moved to an external file?
@SaiSudhaV Thanks for pointing it out.
We can't move those inline styling because that creates a mess or may they overwrite the existing CSS, also if any chance I could move them to the external file they need proper Classes & ID
names for specific HTML element and that's very hard for me to do because those designs aren't implemented by me (Also most of the CSS stylings in the is project directly copy from other sites that's why they even don't have classes and ID's).
P.S: In the future, if those inline CSS creates any kind of problem we can create a new issue for that.
@Aryamanz29 Thanks for clarifying
@Aryamanz29 Thanks for clarifying
@SaiSudhaV @sruti2024 Please add gssoc
and level
label to this PR
Description:
static/css/
.base_BACKUP_1831.html base_BASE_1831.html base_LOCAL_1831.html base_REMOTE_1831.html
) fromtemplates/
gif
below👇Fixes #168
Type of change:
Checklist:
Screenshots / Video 📸:
404 Page working as expected ✔: