sruti2024 / PRO_Act

Pro_Act provides you with an efficient way of managing your tasks. It works on the principals of divide and conquer, allows the user to enter tasks and then divide them into further sub-tasks and handle them efficiently! Best when working with team to be updated about the tasks that are completed and those that are yet to be done.
19 stars 53 forks source link

Move : Internal CSS to External #188

Closed Aryamanz29 closed 3 years ago

Aryamanz29 commented 3 years ago

Description:

Fixes #168

Type of change:

Checklist:

Screenshots / Video 📸:

css_wroking-low

404 Page working as expected ✔:

404

Aryamanz29 commented 3 years ago

@sruti2024 @SaiSudhaV @PROTechThor Need Review for this PR 📝

SaiSudhaV commented 3 years ago

@Aryamanz29 There are some files that still have inline styling. Can't they be moved to an external file?

Aryamanz29 commented 3 years ago

@SaiSudhaV Thanks for pointing it out. We can't move those inline styling because that creates a mess or may they overwrite the existing CSS, also if any chance I could move them to the external file they need proper Classes & ID names for specific HTML element and that's very hard for me to do because those designs aren't implemented by me (Also most of the CSS stylings in the is project directly copy from other sites that's why they even don't have classes and ID's).

P.S: In the future, if those inline CSS creates any kind of problem we can create a new issue for that.

SaiSudhaV commented 3 years ago

@Aryamanz29 Thanks for clarifying

Aryamanz29 commented 3 years ago

@Aryamanz29 Thanks for clarifying

@SaiSudhaV @sruti2024 Please add gssoc and level label to this PR