sruti2024 / PRO_Act

Pro_Act provides you with an efficient way of managing your tasks. It works on the principals of divide and conquer, allows the user to enter tasks and then divide them into further sub-tasks and handle them efficiently! Best when working with team to be updated about the tasks that are completed and those that are yet to be done.

19 stars 53 forks source link

Modified the variable names #191

Closed Furquan712 closed 3 years ago

Furquan712 commented 3 years ago

Description:

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #170

Type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots / Video:

SaiSudhaV commented 3 years ago

@Furquan712 Have you verified whether all the files have proper naming for variables and functions or not?

Furquan712 commented 3 years ago

@SaiSudhaV I have check all the variable. you can recheck if u want....

Aryamanz29 commented 3 years ago

Hii 👋 @Furquan712

Have you tested this commit 008ceb7 before raising this PR since it breaks the login feature of this project?
Have you check that you've replaced all occurrences of variables/function names in other files as well?
Some function names in views.py & models.py still uses camel notation like loginUser() ,signupUser() etc please change them as well.
Please update this PR with working video/gif

@SaiSudhaV Please revert this PR for now and review it again after the completion of the requested changes ✔

See this 👇 Note: I have also check this with the last commit ie. 785cf75 and it works as expected (Found no problem).

login_bug

SaiSudhaV commented 3 years ago

@Aryamanz29 Thank you so much. Sure I'll review it again.