sruti2024 / PRO_Act

Pro_Act provides you with an efficient way of managing your tasks. It works on the principals of divide and conquer, allows the user to enter tasks and then divide them into further sub-tasks and handle them efficiently! Best when working with team to be updated about the tasks that are completed and those that are yet to be done.

19 stars 53 forks source link

Renamed : kebab-case filename to snake_case #194

Closed Srishti013 closed 3 years ago

Srishti013 commented 3 years ago

Description:

I have changed the name of kebab-case files to snake_case.

Fixes # (issue no.) fixes[#165]

Type of change:

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My changes generate no new warnings.

https://user-images.githubusercontent.com/67790510/118239065-ee4cf300-b4b6-11eb-90de-f59d9f9f0846.mov

Aryamanz29 commented 3 years ago

Hii 👋 @Srishti013 PR looks good, but you have to do some minors changes 📝

Change PR title ( should be more descriptive)🎯
I think you may forget issue 4th point👇
- Note: Do changes in the codebase as well if they link into the project.
Please change these rename file names in the codebase as well like in the views.py render function,HTML files link JS files, etc📜
Also don't forget to add a working GIF/Video in the PR description so that we can verify that your work doesn't break any existing feature 🎞

@sruti2024 @SaiSudhaV What do you think?

Aryamanz29 commented 3 years ago

@Srishti013 Nice work 🎉

Now squash your commits (combine all your commits into one single commit) for ref:https://levelup.gitconnected.com/how-to-squash-git-commits-9a095c1bc1fc
Add GIF/Video in the PR description.

Srishti013 commented 3 years ago

Sure

SaiSudhaV commented 3 years ago

Hii 👋 @Srishti013 PR looks good, but you have to do some minors changes 📝

Change PR title ( should be more descriptive)🎯

I think you may forget issue 4th point👇

Note: Do changes in the codebase as well if they link into the project.

Please change these rename file names in the codebase as well like in the views.py render function,HTML files link JS files, etc📜

Also don't forget to add a working GIF/Video in the PR description so that we can verify that your work doesn't break any existing feature 🎞

@sruti2024 @SaiSudhaV What do you think?

Yeah you're right @Srishti013 Please do following things

add working demo video / GIF
Link the PR with the issue you're working on

Srishti013 commented 3 years ago

Hii 👋 @Srishti013 PR looks good, but you have to do some minors changes 📝

Change PR title ( should be more descriptive)🎯

I think you may forget issue 4th point👇

Note: Do changes in the codebase as well if they link into the project.

Please change these rename file names in the codebase as well like in the views.py render function,HTML files link JS files, etc📜

Also don't forget to add a working GIF/Video in the PR description so that we can verify that your work doesn't break any existing feature 🎞

@sruti2024 @SaiSudhaV What do you think?

Yeah you're right @Srishti013 Please do following things

add working demo video / GIF

Link the PR with the issue you're working on

done

Aryamanz29 commented 3 years ago

Hii 👋 @Srishti013 PR looks good, but you have to do some minors changes 📝

Change PR title ( should be more descriptive)🎯

I think you may forget issue 4th point👇

Note: Do changes in the codebase as well if they link into the project.

Please change these rename file names in the codebase as well like in the views.py render function,HTML files link JS files, etc📜

Also don't forget to add a working GIF/Video in the PR description so that we can verify that your work doesn't break any existing feature 🎞

@sruti2024 @SaiSudhaV What do you think?

Yeah you're right @Srishti013 Please do following things

add working demo video / GIF

Link the PR with the issue you're working on

done

@Srishti013 Please squash your commits.