sruti2024 / PRO_Act

Pro_Act provides you with an efficient way of managing your tasks. It works on the principals of divide and conquer, allows the user to enter tasks and then divide them into further sub-tasks and handle them efficiently! Best when working with team to be updated about the tasks that are completed and those that are yet to be done.

19 stars 53 forks source link

[fix]: Multiple project with same name #196

Closed Aryamanz29 closed 3 years ago

Aryamanz29 commented 3 years ago

Description:

Fix: Multiple projects with the same name
Now the user sees the warning before adding a project that already exists.

Fixes #158

Type of change:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots / Video:

add_project

SaiSudhaV commented 3 years ago

@Aryamanz29 I think it would be better if the warning is shown while entering the project name itself before clicking on submit (like if we create a google groups, mail ids, Instagram or some other websites will display an error message showing that the username is available). Can that be done? What do you think about this idea? @sruti2024

Aryamanz29 commented 3 years ago

@Aryamanz29 I think it would be better if the warning is shown while entering the project name itself before clicking on submit (like if we create a google groups, mail ids, Instagram or some other websites will display an error message showing that the username is available). Can that be done? What do you think about this idea? @sruti2024

Sure, I think for this, I need to add constraint in the form itself. I'll try to do this 👍

SaiSudhaV commented 3 years ago

Okay, once you're done with that we'll go for merging

Aryamanz29 commented 3 years ago

@Aryamanz29 I think it would be better if the warning is shown while entering the project name itself before clicking on submit (like if we create a google groups, mail ids, Instagram, or some other websites will display an error message showing that the username is available). Can that be done? What do you think about this idea? @sruti2024

Updates⚡

Added project name suggestion whenever user types on input field of project name using AJAX & added static/js/project_name_validation.js
- Suggestions includes like project already exists, available etc
I haven't remove existing Django alert messages because if someone tries to submit the form with an empty project name it gives back an alert and

redirects the same page and I think which is necessary.

See working 👇

multiple_pro_final-min

Aryamanz29 commented 3 years ago

@SaiSudhaV Please review PR again

SaiSudhaV commented 3 years ago

Woah! Nice looking great. No problem let that default Django alert message. Thanks for your contributions. Keep working.