sruti2024 / PRO_Act

Pro_Act provides you with an efficient way of managing your tasks. It works on the principals of divide and conquer, allows the user to enter tasks and then divide them into further sub-tasks and handle them efficiently! Best when working with team to be updated about the tasks that are completed and those that are yet to be done.
19 stars 53 forks source link

[Fix] : Social auths and Added Github OAuth #205

Closed Aryamanz29 closed 3 years ago

Aryamanz29 commented 3 years ago

Description:

Fixes #193

Type of change:

Checklist:

Screenshots / Video:

Screenshot from 2021-05-29 14-50-51 Screenshot from 2021-05-29 14-50-56

SaiSudhaV commented 3 years ago

@Aryamanz29 Please do attach a working demo video with all the following: case1 : When a user is not registered case2 : When the user is logged in with google or github blocking the entry from the other social account.

Aryamanz29 commented 3 years ago

@Aryamanz29 Please do attach a working demo video with all the following: case1 : When a user is not registered case2 : When the user is logged in with google or github blocking the entry from the other social account.

CASE - 1 When user not registered 👇

auth1

CASE - 2 When user first login with Github then after with Google with the same email registered on both socials, he/she might get this form/error, So it is preferred to use only a single auth service either google or GitHub if you have the same email registered with both social auth in my case ie. aryamanz29@gmail.com 👇

auth2

auth3

SaiSudhaV commented 3 years ago

CASE - 1 When user not registered 👇

auth1

CASE - 2 When user first login with Github then after with Google with the same email registered on both socials, he/she might get this form/error, So it is preferred to use only a single auth service either google or GitHub if you have the same email registered with both social auth in my case ie. aryamanz29@gmail.com 👇

auth2

auth3

In case2 the redirection of login to google accounts, was it default one or was it created in our project?

Aryamanz29 commented 3 years ago

CASE - 1 When user not registered point_down auth1 CASE - 2 When user first login with Github then after with Google with the same email registered on both socials, he/she might get this form/error, So it is preferred to use only a single auth service either google or GitHub if you have the same email registered with both social auth in my case ie. aryamanz29@gmail.com point_down auth2 auth3

In case2 the redirection of login to google accounts, was it default one or was it created in our project?

In case2 first gif , I show you that both GitHub and Google auth sevice won't work if user have same registered email , but in second gif of case2 or gif of case1 you see that he/she can use either GitHub or google but not both.