search

sruusk / esea-scraper

A consumable Node package to scrape data from ESEA API
https://www.npmjs.com/package/esea-scraper
Other
3 stars 2 forks source link

getPlayerFromSteamId64 method #190

Closed saddiqs1 closed 1 year ago

saddiqs1 commented 1 year ago

getPlayerFromSteamId64 method, fixed typescript/linting errors, updated readme

saddiqs1 commented 1 year ago

Thinking about it, the code could probably be cleaned up a little more to make the calls a bit more modular and clear for when future calls are added, i.e. moving fetch(hero: Omit<Hero, 'then'>, url: string): Promise<any> from player.ts to a generic helper file somewhere, and then having player.ts purely responsible for retrieving information related to a players esea profile. You could then make a seperate teams.ts file for example in the future which contains calls to retrieve team info

sruusk commented 1 year ago

Thanks for this. The code could certainly be cleaned a lot, but I currently have no intention of building this much further than it is currently. But if you need some features added feel free to open a pull request. :)

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: