srv / avt_vimba_camera

ROS Driver for AVT cameras using VIMBA SDK
23 stars 93 forks source link

Can the camera Gamma parameter be set? #20

Open shaun-edwards opened 7 years ago

shaun-edwards commented 7 years ago

I set the camera Gamma using the AVT Viewer application. However, when I connect to the camera via ROS the Gamma appears to be reset. Does the ROS driver "reset" the camera parameters? If so, is there a way to set the Gamma via the driver/launch file?

miquelmassot commented 7 years ago

It is not implemented, but it should be easy to do. Just take a look at how the gain is set here and do the same with your gamma. Uncomment this line to see all your camera parameters, names and limits.

shaun-edwards commented 7 years ago

@miquelmassot, thanks for the info. Would you be interested in a PR that implements this?

miquelmassot commented 7 years ago

Sure, why not? Please let me know.

shaun-edwards commented 7 years ago

The gain example is contained within void AvtVimbaCamera::updateGainConfig(Config& config). Do you suggest I include the Gamma in that method or another one?

Also, can you answer my question about whether the driver resets parameters? I expected the Gamma to stay set, but that doesn't seem to be the case.

JWhitleyWork commented 4 years ago

This fork is no longer actively maintained. Please see our new fork at https://github.com/astuff/avt_vimba_camera, which has been updated and recently released.