Work in progress, looking for feedback....DO NOT MERGE
This PR addresses issue #21 and includes PR #22.
The node now waits for the camera to be connected before starting up. I made changes to the CameraPtr AvtVimbaCamera::openCamera(std::string id_str) method in src/avt_vimba_camera.cpp.
I'm looking for feedback on these changes. I am not a fan of using ros::ok(), since it does introduce ROS at a layer where is probably doesn't belong. However, without this, the node does not respond properly to a Ctrl-C. I also do not like how the vimba_system must be restarted. I'm not familar with the API, so this was basically a result of guessing and testing. However, without the restart, the system never recognizes a camera, even once it's plugged in.
miquelmassot
commented
7 years ago
Work in progress, looking for feedback....DO NOT MERGE
This PR addresses issue #21 and includes PR #22.
The node now waits for the camera to be connected before starting up. I made changes to the
CameraPtr AvtVimbaCamera::openCamera(std::string id_str)method insrc/avt_vimba_camera.cpp.I'm looking for feedback on these changes. I am not a fan of using
ros::ok(), since it does introduce ROS at a layer where is probably doesn't belong. However, without this, the node does not respond properly to aCtrl-C. I also do not like how thevimba_systemmust be restarted. I'm not familar with the API, so this was basically a result of guessing and testing. However, without the restart, the system never recognizes a camera, even once it's plugged in.