search

srv / avt_vimba_camera

ROS Driver for AVT cameras using VIMBA SDK
23 stars 93 forks source link

Binary release into ROS Kinetic #27

Closed 130s closed 7 years ago

130s commented 7 years ago

As I mentioned in https://github.com/srv/avt_vimba_camera/pull/26, ROS pre-release test passed for ROS K (and L as well).

Thanks!

130s commented 7 years ago

https://github.com/ros/rosdistro/pull/15785 🎆

mikaelarguedas commented 7 years ago

@130s @miquelmassot FYI: Looks like this fails to build on arm64 (ubuntu xenial and debian stretch)

mikaelarguedas commented 7 years ago

@miquelmassot I see that there is no libraries for arm_64bits in this package. Is this something that will be added in the near future ? or should this package be disabled for arm64 platforms?

miquelmassot commented 7 years ago

Yes please, I don't know how to disable it for arm, could you please let me know how?

On 17 Aug 2017 9:47 a.m., "Mikael Arguedas" notifications@github.com wrote:

@miquelmassot https://github.com/miquelmassot I see that there is no libraries for arm_64bits in this package. Is this something that will be added in the near future ? or should this package be disabled for arm64 platforms?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/srv/avt_vimba_camera/issues/27#issuecomment-322995139, or mute the thread https://github.com/notifications/unsubscribe-auth/ABiVjHmjDt4-2kPfMyn12ser_gsquK92ks5sY-_5gaJpZM4Oriw- .

mikaelarguedas commented 7 years ago

Thanks for the quick reply. Blacklisting packages for specific architectures is not something we can do through bloom and thus is an extra step after releasing. To blacklist a package you need to open a PR on ros_buildfarm_config against the production branch. In that repo there is a folder for each ROS distribution. and in each folder a set of yaml files for the different platforms/architectures. I created a PR here to disable the package for lunar (the 2 platforms we build arm64 bit packages: Ubuntu Xenial and Debian Stretch).

Once https://github.com/ros/rosdistro/pull/15785 is merged you will need to do the same on ROS Kinetic (for Ubuntu Xenial and Debian Jessie).

Cheers!

miquelmassot commented 7 years ago

Thanks @mikaelarguedas, it should be solved now.

mikaelarguedas commented 7 years ago

@miquelmassot you will need to fix the branch name in https://github.com/ros/rosdistro/pull/15785 to point to kinetic for this package to be released in kinetic