search

srvrco / getssl

obtain free SSL certificates from letsencrypt ACME server Suitable for automating the process on remote servers.
GNU General Public License v3.0
2.08k stars 373 forks source link

Add a User-Agent header #453

Closed jsha closed 4 years ago

jsha commented 4 years ago

I've been looking at Let's Encrypt logs, and I notice a number of entries that just have User-Agent: curl/x.y.z. It looks like getssl doesn't currently set this header explicitly. It would be really helpful if it did! Here's what the ACME RFC has to say on User-Agent:

https://tools.ietf.org/html/rfc8555#page-10

ACME clients MUST send a User-Agent header field, in accordance with [RFC7231]. This header field SHOULD include the name and version of the ACME software in addition to the name and version of the underlying HTTP client software.

Thanks, Jacob

cpu commented 4 years ago

@serverco-a @timkimber @EmiiKhaos Do you folks think it might be possible to address this before a new release is cut with the recently merged ACME v2 support? I think that new code is going to prompt a lot of users to update their getssl installations and I'd love to see them send a UA on day 1 of using the V2 API.

timkimber commented 4 years ago

Just done a PR to address this issue - just need @serverco-a or @EmiiKhaos to review it